https://codereview.chromium.org/771483002/diff/170001/src/runtime/runtime-array.cc
File src/runtime/runtime-array.cc (right):
https://codereview.chromium.org/771483002/diff/170001/src/runtime/runtime-array.cc#newcode583
src/runtime/runtime-array.cc:583:
IterateExternalArrayElements<FixedInt8Array, int8_t>(
Please rename IterateExternalArrayElements into
IterateTypedArrayElements (this no longer only iterates externals)
https://codereview.chromium.org/771483002/diff/170001/test/mjsunit/harmony/array-concat.js
File test/mjsunit/harmony/array-concat.js (right):
https://codereview.chromium.org/771483002/diff/170001/test/mjsunit/harmony/array-concat.js#newcode122
test/mjsunit/harmony/array-concat.js:122: var ta = new type(items);
The reason why you are not hitting UINT8_ELEMENTS and friends, only
EXTERNAL_UINT8_ELEMENTS and friends, is because only new
TypedArray(length) call allocates in-heap typed arrays.
Remove `items` and initialize `ta` directly - then you should hit the
cases you have added.
https://codereview.chromium.org/771483002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
