https://codereview.chromium.org/797233002/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/797233002/diff/1/src/arm/assembler-arm.cc#newcode133
src/arm/assembler-arm.cc:133: supported_ |= 1u << COHERENT_CACHE;
Nit: Add { and } for block.
https://codereview.chromium.org/797233002/diff/1/src/arm64/assembler-arm64.cc
File src/arm64/assembler-arm64.cc (right):
https://codereview.chromium.org/797233002/diff/1/src/arm64/assembler-arm64.cc#newcode53
src/arm64/assembler-arm64.cc:53: supported_ |= 1u << COHERENT_CACHE;
Nit: Add { and } for block.
https://codereview.chromium.org/797233002/diff/1/src/base/cpu.cc
File src/base/cpu.cc (right):
https://codereview.chromium.org/797233002/diff/1/src/base/cpu.cc#newcode303
src/base/cpu.cc:303: variant_(-1),
Can we default to 0 here instead?
https://codereview.chromium.org/797233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
