Addressed the new comment from rmcilroy. PTAL
I used git commit --amend to update the commit message and that did not
reflect
here when I next did git cl upload. I had to do git-cl description and git
cl
upload and then it worked.
JF,
I just now noticed that I left out one comment of yours. Did you mean to say
updating variant_ through CPUID is a better way than through ExtractField()?
Should I change that also?
Otherwise I think I addressed everyone's comments.
https://codereview.chromium.org/797233002/diff/20001/src/arm64/assembler-arm64.cc
File src/arm64/assembler-arm64.cc (right):
https://codereview.chromium.org/797233002/diff/20001/src/arm64/assembler-arm64.cc#newcode63
src/arm64/assembler-arm64.cc:63: void CpuFeatures::PrintFeatures() { }
On 2014/12/18 14:05:07, rmcilroy wrote:
Please update PrintFeatures to output COHERENT_CACHE status (as with
Arm).
Done.
https://codereview.chromium.org/797233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
