Addressed all your comments.
PTAL
https://codereview.chromium.org/797233002/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/797233002/diff/1/src/arm/assembler-arm.cc#newcode133
src/arm/assembler-arm.cc:133: supported_ |= 1u << COHERENT_CACHE;
On 2014/12/15 05:33:36, Benedikt Meurer wrote:
Nit: Add { and } for block.
Done.
https://codereview.chromium.org/797233002/diff/1/src/arm64/assembler-arm64.cc
File src/arm64/assembler-arm64.cc (right):
https://codereview.chromium.org/797233002/diff/1/src/arm64/assembler-arm64.cc#newcode48
src/arm64/assembler-arm64.cc:48: supported_ = 0;
On 2014/12/15 16:32:02, rmcilroy wrote:
On 2014/12/15 16:23:23, JF wrote:
> The ARM and x64 version of this file also have:
>
>
> // Only use statically determined features for cross compile
(snapshot).
> if (cross_compile) return;
>
> Shoud this fie also do this?
Yes you will need this here otherwise the snapshot might get generated
wrongly.
Done.
https://codereview.chromium.org/797233002/diff/1/src/arm64/assembler-arm64.cc#newcode53
src/arm64/assembler-arm64.cc:53: supported_ |= 1u << COHERENT_CACHE;
On 2014/12/15 05:33:36, Benedikt Meurer wrote:
Nit: Add { and } for block.
Done.
https://codereview.chromium.org/797233002/diff/1/src/base/cpu.cc
File src/base/cpu.cc (right):
https://codereview.chromium.org/797233002/diff/1/src/base/cpu.cc#newcode303
src/base/cpu.cc:303: variant_(-1),
On 2014/12/15 05:33:36, Benedikt Meurer wrote:
Can we default to 0 here instead?
Done.
https://codereview.chromium.org/797233002/diff/1/src/base/cpu.cc#newcode405
src/base/cpu.cc:405: variant_ = 0;
Yes. Denver is identified as 0 in variant.
Recently released Shield Tablet has 0x3 as variant which is a Tegra chip
but doesn't have a Denver CPU.
I changed the failure case to be -1.
https://codereview.chromium.org/797233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
