https://codereview.chromium.org/941973002/diff/20001/src/cpu-profiler.h
File src/cpu-profiler.h (right):
https://codereview.chromium.org/941973002/diff/20001/src/cpu-profiler.h#newcode243
src/cpu-profiler.h:243: virtual void SharedFunctionInfoMoveEvent(Address
from, Address to) {}
Can we remove dependency of the logger on this method and remove it
altogether? I suspect the use this event for the same purpose as we do
in CPU profiler.
https://codereview.chromium.org/941973002/diff/20001/src/profile-generator.cc
File src/profile-generator.cc (left):
https://codereview.chromium.org/941973002/diff/20001/src/profile-generator.cc#oldcode175
src/profile-generator.cc:175: hash ^=
ComputeIntegerHash(static_cast<uint32_t>(shared_id_),
Given that we (wrongly) assume externally that GetCllUid returns
ProfileNode's unique id this change might increase probability of
collision and lead to some errors. Let's first rename this method to
GetHash() and have GetCallUid return unique id. After that it should be
safe to change this method. Eventually we should drop GetCallUid from
external API in favor of script_id + position.
https://codereview.chromium.org/941973002/diff/20001/src/profile-generator.cc
File src/profile-generator.cc (right):
https://codereview.chromium.org/941973002/diff/20001/src/profile-generator.cc#newcode221
src/profile-generator.cc:221: if (shared->script()->IsScript()) {
if (!shared->script()->IsScript()) return;
https://codereview.chromium.org/941973002/diff/20001/src/profile-generator.cc#newcode222
src/profile-generator.cc:222: DCHECK(Script::cast(shared->script()));
Remove this
https://codereview.chromium.org/941973002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
