On 2015/02/20 12:29:29, yurys wrote:
https://codereview.chromium.org/941973002/diff/100001/src/profile-generator.cc
File src/profile-generator.cc (right):
https://codereview.chromium.org/941973002/diff/100001/src/profile-generator.cc#newcode351
src/profile-generator.cc:351: function_ids_.Lookup(code_entry,
code_entry->GetHash(), true);
Would it make sense to store the map on ProfileGenerator next to CodeMap?
Otherwise we'll have it duplicated in each ProfileTree.
We delete profile immediately after taking profile.
When we get a new CodeEntry we delete old entries from CodeMap if they
overlap
by address range with the new one.
If we put function_ids map into profile generator then it will continuously
grow.
In this case we need to clean it manually so we will loose the persistency.
As a result we will get no benefits from this and additional code.
https://codereview.chromium.org/941973002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
