https://codereview.chromium.org/941973002/diff/20001/src/cpu-profiler.h
File src/cpu-profiler.h (right):
https://codereview.chromium.org/941973002/diff/20001/src/cpu-profiler.h#newcode243
src/cpu-profiler.h:243: virtual void SharedFunctionInfoMoveEvent(Address
from, Address to) {}
On 2015/02/20 10:17:16, yurys wrote:
Can we remove dependency of the logger on this method and remove it
altogether?
I suspect the use this event for the same purpose as we do in CPU
profiler.
I'd do this in another patch
https://codereview.chromium.org/941973002/diff/20001/src/profile-generator.cc
File src/profile-generator.cc (right):
https://codereview.chromium.org/941973002/diff/20001/src/profile-generator.cc#newcode221
src/profile-generator.cc:221: if (shared->script()->IsScript()) {
On 2015/02/20 10:17:16, yurys wrote:
if (!shared->script()->IsScript()) return;
Done.
https://codereview.chromium.org/941973002/diff/20001/src/profile-generator.cc#newcode222
src/profile-generator.cc:222: DCHECK(Script::cast(shared->script()));
On 2015/02/20 10:17:16, yurys wrote:
Remove this
Done.
https://codereview.chromium.org/941973002/diff/20001/src/profile-generator.cc#newcode225
src/profile-generator.cc:225: set_position(shared->start_position());
On 2015/02/20 10:26:35, alph wrote:
Can we just add the uid to SharedFunctionInfo?
Done.
https://codereview.chromium.org/941973002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
