https://codereview.chromium.org/941973002/diff/20001/src/profile-generator.cc
File src/profile-generator.cc (left):
https://codereview.chromium.org/941973002/diff/20001/src/profile-generator.cc#oldcode175
src/profile-generator.cc:175: hash ^=
ComputeIntegerHash(static_cast<uint32_t>(shared_id_),
On 2015/02/20 10:17:16, yurys wrote:
Given that we (wrongly) assume externally that GetCllUid returns
ProfileNode's
unique id this change might increase probability of collision and lead
to some
errors. Let's first rename this method to GetHash() and have
GetCallUid return
unique id. After that it should be safe to change this method.
Eventually we
should drop GetCallUid from external API in favor of script_id +
position.
It is not a ProfileNode unique ID but CodeEntry "UniqueID" so many
ProfileNodes could have the same CallUid. I.e. it is a function id.
https://codereview.chromium.org/941973002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
