Looks good, pretty clean. Mostly just naming nits.
https://codereview.chromium.org/949743002/diff/130001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/949743002/diff/130001/src/compiler/ast-graph-builder.cc#newcode548
src/compiler/ast-graph-builder.cc:548:
relaxer.Blacklist(arguments->index());
Maybe "MarkPermanentlyLive(int index)" as a better name?
https://codereview.chromium.org/949743002/diff/130001/src/compiler/ast-graph-builder.cc#newcode665
src/compiler/ast-graph-builder.cc:665: void
AstGraphBuilder::Environment::MakeAllLocalsLive() {
Make -> Mark?
https://codereview.chromium.org/949743002/diff/130001/src/compiler/ast-graph-builder.h
File src/compiler/ast-graph-builder.h (right):
https://codereview.chromium.org/949743002/diff/130001/src/compiler/ast-graph-builder.h#newcode273
src/compiler/ast-graph-builder.h:273: void
RelaxFrameStatesWithLiveness();
Can we use another word than "Relax", here and elsewhere? E.g. this
method might be better called "ClearNonLiveFrameStateSlots" or something
similar.
https://codereview.chromium.org/949743002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
