A coupla' nits.
https://codereview.chromium.org/949743002/diff/130001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/949743002/diff/130001/src/compiler/ast-graph-builder.cc#newcode674
src/compiler/ast-graph-builder.cc:674: AstGraphBuilder::Environment*
AstGraphBuilder::Environment::Snapshot() {
nit: How about s/Snapshot/CopyAndShareLiveness/ here, or anything else
that starts with the "Copy" prefix?
https://codereview.chromium.org/949743002/diff/130001/src/compiler/ast-graph-builder.h
File src/compiler/ast-graph-builder.h (right):
https://codereview.chromium.org/949743002/diff/130001/src/compiler/ast-graph-builder.h#newcode359
src/compiler/ast-graph-builder.h:359: // shifted by 1 (receiver is
parameter index -1 but environment index 0).
nit: I think the second sentence in the comment makes more sense for the
implementation, not the interface. Can we move it to where the magic
off-by one calculation is performed?
https://codereview.chromium.org/949743002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
