I don't have any more constructive feedback on this CL. Please choose
another
reviewer to approve this change.
https://codereview.chromium.org/949743002/diff/130001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/949743002/diff/130001/src/compiler/ast-graph-builder.cc#newcode533
src/compiler/ast-graph-builder.cc:533:
graph()->SetEnd(NewNode(common()->End()));
This duplicates the end node, please don't do this.
https://codereview.chromium.org/949743002/diff/130001/src/compiler/ast-graph-builder.cc#newcode537
src/compiler/ast-graph-builder.cc:537: RelaxFrameStatesWithLiveness();
Rather move this call into CreateGraph() a few lines above.
https://codereview.chromium.org/949743002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
