https://codereview.chromium.org/949743002/diff/210001/src/compiler/ast-graph-builder.h
File src/compiler/ast-graph-builder.h (right):
https://codereview.chromium.org/949743002/diff/210001/src/compiler/ast-graph-builder.h#newcode107
src/compiler/ast-graph-builder.h:107: LivenessAnalyzer*
liveness_analyzer_;
Chromium style guide nit again: Don't turn into pointer just to be able
to forward declare.
https://codereview.chromium.org/949743002/diff/210001/src/compiler/liveness-analyzer.cc
File src/compiler/liveness-analyzer.cc (right):
https://codereview.chromium.org/949743002/diff/210001/src/compiler/liveness-analyzer.cc#newcode60
src/compiler/liveness-analyzer.cc:60: BitVector
working_area(local_count_ == 0 ? 1 : static_cast<int>(local_count_),
Is it worth adding a shortcut of the rest for local_count_ == 0? In that
case you just need to setup the live_ target bit vector unless I'm
missing something?
https://codereview.chromium.org/949743002/diff/210001/src/compiler/liveness-analyzer.h
File src/compiler/liveness-analyzer.h (right):
https://codereview.chromium.org/949743002/diff/210001/src/compiler/liveness-analyzer.h#newcode54
src/compiler/liveness-analyzer.h:54: class LivenessAnalyzer : public
ZoneObject {
Chromium style guide nit (see above): No need to inherit from ZoneObject
here.
https://codereview.chromium.org/949743002/diff/210001/src/compiler/liveness-analyzer.h#newcode58
src/compiler/liveness-analyzer.h:58: LivenessAnalyzerBlock* New();
Nit: Rename to NewBlock.
https://codereview.chromium.org/949743002/diff/210001/src/compiler/liveness-analyzer.h#newcode59
src/compiler/liveness-analyzer.h:59: LivenessAnalyzerBlock*
New(LivenessAnalyzerBlock* predecessor);
Nit: Rename to NewBlock.
https://codereview.chromium.org/949743002/diff/210001/src/compiler/liveness-analyzer.h#newcode115
src/compiler/liveness-analyzer.h:115: LivenessAnalyzerBlock(size_t id,
size_t local_count, Zone* zone)
Nit: Move implementation to .cc file.
https://codereview.chromium.org/949743002/diff/210001/src/compiler/state-values-utils.cc
File src/compiler/state-values-utils.cc (right):
https://codereview.chromium.org/949743002/diff/210001/src/compiler/state-values-utils.cc#newcode175
src/compiler/state-values-utils.cc:175: DCHECK_NE(values[i]->opcode(),
IrOpcode::kStateValues);
Nit: expected, actual
https://codereview.chromium.org/949743002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
