https://codereview.chromium.org/913073003/diff/120001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/913073003/diff/120001/src/bootstrapper.cc#newcode2930
src/bootstrapper.cc:2930: // Shouldn't InitializeExperimentalGlobal()
happen before
Dmitry fixed this I believe.
https://codereview.chromium.org/913073003/diff/120001/src/runtime.js
File src/runtime.js (right):
https://codereview.chromium.org/913073003/diff/120001/src/runtime.js#newcode490
src/runtime.js:490: var ctorOk = IS_SPEC_FUNCTION(this) &&
%IsConstructor(this);
This runtime function makes me sad. I see that you have a todo in
Runtime_IsConstructor...
https://codereview.chromium.org/913073003/diff/120001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):
https://codereview.chromium.org/913073003/diff/120001/src/x64/builtins-x64.cc#newcode1232
src/x64/builtins-x64.cc:1232: static void
Generate_ConstructHelper(MacroAssembler* masm) {
Can the code in here be better shared with Generate_ApplyHelper?
https://codereview.chromium.org/913073003/diff/120001/test/mjsunit/harmony/reflect-construct.js
File test/mjsunit/harmony/reflect-construct.js (right):
https://codereview.chromium.org/913073003/diff/120001/test/mjsunit/harmony/reflect-construct.js#newcode51
test/mjsunit/harmony/reflect-construct.js:51: assertSame(1, O[9]);
also check length and Array.isArray to ensure we created an exotic array
object.
https://codereview.chromium.org/913073003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
