On 2015/03/12 11:44:13, Dmitry Lomov (chromium) wrote:
On 2015/03/11 17:54:47, caitp wrote:
> dslomov@ do you have an opinion on what Erik was saying, about sharing
more
code
> between ApplyHelper and ConstructHelper?
>
> I personally felt that it made it much harder to read, and the only
thing
that
> can really be shared is the looping over the arguments array.
>
> If there's no opinion, I'll start working on ports so that it can land
The arguments copying loop is big and scary - if we could share that that
would
be a win I think.
It's not really that much code, I've put up a version where the looping is
shared though. I would not look at the inter-diff because the rebase was
included in that patchset, but it should be pretty easy to see it.
If that looks alright, I'll start working on some ports
https://codereview.chromium.org/913073003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
