https://codereview.chromium.org/913073003/diff/120001/test/mjsunit/harmony/reflect-construct.js
File test/mjsunit/harmony/reflect-construct.js (right):
https://codereview.chromium.org/913073003/diff/120001/test/mjsunit/harmony/reflect-construct.js#newcode51
test/mjsunit/harmony/reflect-construct.js:51: assertSame(1, O[9]);
On 2015/03/04 13:30:33, arv wrote:
On 2015/03/04 13:24:14, caitp wrote:
> On 2015/03/04 09:45:01, arv wrote:
> > also check length and Array.isArray to ensure we created an exotic
array
> object.
>
> That's not exactly correct:
>
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-ordinarycreatefromconstructor
> --- It's an ordinary object with the Array prototype.
You are right.
Maybe a more interesting test then would be `Reflect.construct(Array,
[5],
Constructor)`.
Hmm, we seem to be doing something wrong though. If `target` is a
builtin function, the result ends up being an exotic <<whatever>>,
regardless of what `newTarget` is, even though it gets the right
prototype. I don't think that's correct.
https://codereview.chromium.org/913073003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
