https://codereview.chromium.org/913073003/diff/120001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/913073003/diff/120001/src/bootstrapper.cc#newcode2930
src/bootstrapper.cc:2930: // Shouldn't InitializeExperimentalGlobal()
happen before
On 2015/03/04 09:45:01, arv wrote:
Dmitry fixed this I believe.
Fix hasn't landed yet, but yes it will be changed when it does
https://codereview.chromium.org/913073003/diff/120001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):
https://codereview.chromium.org/913073003/diff/120001/src/x64/builtins-x64.cc#newcode1232
src/x64/builtins-x64.cc:1232: static void
Generate_ConstructHelper(MacroAssembler* masm) {
On 2015/03/04 09:45:01, arv wrote:
Can the code in here be better shared with Generate_ApplyHelper?
It was my first approach, but it made things really, really hard to
follow. It might be better to factor the shared bits into smaller
functions
https://codereview.chromium.org/913073003/diff/120001/test/mjsunit/harmony/reflect-construct.js
File test/mjsunit/harmony/reflect-construct.js (right):
https://codereview.chromium.org/913073003/diff/120001/test/mjsunit/harmony/reflect-construct.js#newcode51
test/mjsunit/harmony/reflect-construct.js:51: assertSame(1, O[9]);
On 2015/03/04 09:45:01, arv wrote:
also check length and Array.isArray to ensure we created an exotic
array object.
That's not exactly correct:
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-ordinarycreatefromconstructor
--- It's an ordinary object with the Array prototype.
https://codereview.chromium.org/913073003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
