Thanks for having a look.
dslomov@, class_scope, yay or nay?
https://codereview.chromium.org/968263002/diff/140001/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/968263002/diff/140001/src/scopes.cc#newcode802
src/scopes.cc:802: return "class";
On 2015/03/04 10:39:27, rossberg wrote:
Nit: format like others.
clang-format wants it this way :/ Instead, formatted the others like
this.
https://codereview.chromium.org/968263002/diff/140001/src/scopes.cc#newcode1144
src/scopes.cc:1144: found_method_scope = true;
On 2015/03/04 10:39:27, rossberg wrote:
Can't we simplify the logic by returning true here right away?
Done.
https://codereview.chromium.org/968263002/diff/140001/test/mjsunit/strong/declaration-after-use.js
File test/mjsunit/strong/declaration-after-use.js (right):
https://codereview.chromium.org/968263002/diff/140001/test/mjsunit/strong/declaration-after-use.js#newcode184
test/mjsunit/strong/declaration-after-use.js:184: class C4 { method() {
C4; } }; new C4();
On 2015/03/04 10:39:27, rossberg wrote:
PErhaps add a third test using a static method.
Done.
https://codereview.chromium.org/968263002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
