Thanks for comments! arv@, lgty?
https://codereview.chromium.org/968263002/diff/220001/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/968263002/diff/220001/src/scopes.cc#newcode1455
src/scopes.cc:1455: if (!IsConciseMethod(function_kind_) &&
!IsConstructor(function_kind_)) {
On 2015/03/07 18:17:10, Dmitry Lomov (chromium) wrote:
On 2015/03/06 16:37:24, arv wrote:
> This should include IsAccessorFunction too.
+ test
Done.
https://codereview.chromium.org/968263002/diff/220001/src/scopes.cc#newcode1455
src/scopes.cc:1455: if (!IsConciseMethod(function_kind_) &&
!IsConstructor(function_kind_)) {
On 2015/03/06 16:37:24, arv wrote:
This should include IsAccessorFunction too.
Done.
https://codereview.chromium.org/968263002/diff/220001/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/968263002/diff/220001/src/scopes.h#newcode285
src/scopes.h:285: void tag_as_class_scope() {
block_scope_is_class_scope_ = true; }
On 2015/03/06 16:37:24, arv wrote:
DCHECK(is_block_scope());
Done.
https://codereview.chromium.org/968263002/diff/220001/test/mjsunit/strong/declaration-after-use.js
File test/mjsunit/strong/declaration-after-use.js (right):
https://codereview.chromium.org/968263002/diff/220001/test/mjsunit/strong/declaration-after-use.js#newcode169
test/mjsunit/strong/declaration-after-use.js:169: // "
[({ m() { CInner; return 'A'; } }).m()]() { return 'B'; }\n" +
On 2015/03/07 18:17:10, Dmitry Lomov (chromium) wrote:
line length
Done.
https://codereview.chromium.org/968263002/diff/220001/test/mjsunit/strong/declaration-after-use.js#newcode254
test/mjsunit/strong/declaration-after-use.js:254: // Here we can refer
to COuter but not to CInner (see corresponding assertion test):
On 2015/03/07 18:17:10, Dmitry Lomov (chromium) wrote:
line length
Done.
https://codereview.chromium.org/968263002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
