lgtm from my side % arv@'s and mine comments
https://codereview.chromium.org/968263002/diff/200001/test/mjsunit/strong/declaration-after-use.js
File test/mjsunit/strong/declaration-after-use.js (right):
https://codereview.chromium.org/968263002/diff/200001/test/mjsunit/strong/declaration-after-use.js#newcode218
test/mjsunit/strong/declaration-after-use.js:218: let C8 = class C9 {
static method() { C9; } }; new C8();
On 2015/03/06 16:14:23, marja wrote:
On 2015/03/06 14:48:01, Dmitry Lomov (chromium) wrote:
> Add a test for inner class referencing outer class:
>
> class COuter {
> m() {
> class CInner {
> n() {
> COuter();
> }
> }
> }
> }
>
> Also the same for object literal method
Done (not sure what you meant w/ object literal method here, did you
mean object
literal method inside a computed property name? ptal if the test I
added matches
w/ what you meant.
Yes, it does
https://codereview.chromium.org/968263002/diff/220001/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/968263002/diff/220001/src/scopes.cc#newcode1455
src/scopes.cc:1455: if (!IsConciseMethod(function_kind_) &&
!IsConstructor(function_kind_)) {
On 2015/03/06 16:37:24, arv wrote:
This should include IsAccessorFunction too.
+ test
https://codereview.chromium.org/968263002/diff/220001/test/mjsunit/strong/declaration-after-use.js
File test/mjsunit/strong/declaration-after-use.js (right):
https://codereview.chromium.org/968263002/diff/220001/test/mjsunit/strong/declaration-after-use.js#newcode169
test/mjsunit/strong/declaration-after-use.js:169: // "
[({ m() { CInner; return 'A'; } }).m()]() { return 'B'; }\n" +
line length
https://codereview.chromium.org/968263002/diff/220001/test/mjsunit/strong/declaration-after-use.js#newcode254
test/mjsunit/strong/declaration-after-use.js:254: // Here we can refer
to COuter but not to CInner (see corresponding assertion test):
line length
https://codereview.chromium.org/968263002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
