lgtm
https://codereview.chromium.org/1045753002/diff/50001/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/1045753002/diff/50001/include/v8-profiler.h#newcode102
include/v8-profiler.h:102: /** Retrieves a child node by index. */
The comment belongs to the second function.
https://codereview.chromium.org/1045753002/diff/50001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/1045753002/diff/50001/test/cctest/test-cpu-profiler.cc#newcode59
test/cctest/test-cpu-profiler.cc:59: static unsigned int offset(const
char* src, const char* substring) {
could you please add a check that strstr is not null.
https://codereview.chromium.org/1045753002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
