https://codereview.chromium.org/1045753002/diff/90001/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/1045753002/diff/90001/include/v8-profiler.h#newcode25
include/v8-profiler.h:25: unsigned int position;
On 2015/03/30 20:33:15, yurys wrote:
unsigned int -> unsigned
I think that size_t is the right type here, isn't it? It might be the
case that we have wrong types internally, but at least we should get
things right on the external API.
https://codereview.chromium.org/1045753002/diff/90001/include/v8-profiler.h#newcode27
include/v8-profiler.h:27: const char* deopt_reason;
Add a comment about ownership here, naked pointer are always a bit
vague...
https://codereview.chromium.org/1045753002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
