DBC.

Please wait with landing any API changes until after the upcoming branch point. (I see that these changes by themselves are backwards compatible, but we need rollback flexibility, and the only way to ensure that no Chrome/Blink features start depending on new V8 versions is by not landing API changes in the first
place.)


https://codereview.chromium.org/1045753002/diff/70001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/1045753002/diff/70001/test/cctest/test-cpu-profiler.cc#newcode61
test/cctest/test-cpu-profiler.cc:61: ASSERT(it);
You mean DCHECK.

https://codereview.chromium.org/1045753002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to