https://codereview.chromium.org/1045753002/diff/70001/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/1045753002/diff/70001/include/v8-profiler.h#newcode25
include/v8-profiler.h:25: unsigned int position;
unsigned
https://codereview.chromium.org/1045753002/diff/70001/include/v8-profiler.h#newcode40
include/v8-profiler.h:40: unsigned GetFramesCount() const;
Why not return a pointer/reference to std::vector<Frame> which would be
more concise and efficient. AFAIU there is no taboo on using STL in V8
public API anymore, right?
https://codereview.chromium.org/1045753002/diff/70001/include/v8-profiler.h#newcode43
include/v8-profiler.h:43: bool GetCallFrames(Frame* frames, unsigned int
length) const;
ditto
https://codereview.chromium.org/1045753002/diff/70001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1045753002/diff/70001/src/api.cc#newcode7523
src/api.cc:7523: DCHECK_LT(index, node->deopt_infos().size());
Drop this as List already performs such checks.
https://codereview.chromium.org/1045753002/diff/70001/src/api.cc#newcode7542
src/api.cc:7542: bool CpuProfileDeoptInfo::GetCallFrames(Frame* frames,
Return number of written frames?
https://codereview.chromium.org/1045753002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
