https://codereview.chromium.org/1045753002/diff/90001/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/1045753002/diff/90001/include/v8-profiler.h#newcode25
include/v8-profiler.h:25: unsigned int position;
On 2015/03/31 at 06:53:49, yurys wrote:
On 2015/03/31 06:27:09, Sven Panne wrote:
> On 2015/03/30 20:33:15, yurys wrote:
> > unsigned int -> unsigned
>
> I think that size_t is the right type here, isn't it? It might be
the case that
> we have wrong types internally, but at least we should get things
right on the
> external API.
Agree, size_t would be even better.
done
https://codereview.chromium.org/1045753002/diff/90001/include/v8-profiler.h#newcode27
include/v8-profiler.h:27: const char* deopt_reason;
On 2015/03/31 at 06:27:09, Sven Panne wrote:
Add a comment about ownership here, naked pointer are always a bit
vague...
done
https://codereview.chromium.org/1045753002/diff/90001/src/profile-generator.h
File src/profile-generator.h (right):
https://codereview.chromium.org/1045753002/diff/90001/src/profile-generator.h#newcode40
src/profile-generator.h:40: typedef v8::CpuProfileDeoptInfo DeoptInfo;
On 2015/03/30 at 20:33:16, yurys wrote:
Can we use original type without the alias. It seems to be more clear.
done
https://codereview.chromium.org/1045753002/diff/90001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/1045753002/diff/90001/test/cctest/test-cpu-profiler.cc#newcode59
test/cctest/test-cpu-profiler.cc:59: static unsigned int offset(const
char* src, const char* substring) {
On 2015/03/30 at 20:33:16, yurys wrote:
unsigned int -> unsigned
done
https://codereview.chromium.org/1045753002/diff/90001/test/cctest/test-cpu-profiler.cc#newcode62
test/cctest/test-cpu-profiler.cc:62: return static_cast<unsigned int>(it
- src);
On 2015/03/30 at 20:33:16, yurys wrote:
unsigned int -> unsigned
done
https://codereview.chromium.org/1045753002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
