Makes sense to me % some comments.
Let's add some V8 folk here?
https://codereview.chromium.org/1113233002/diff/20001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/1113233002/diff/20001/include/v8.h#newcode5222
include/v8.h:5222: size_t NumberOfHeapObjectsTypes();
This doesn't seem to be defined anywhere ?
https://codereview.chromium.org/1113233002/diff/20001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1113233002/diff/20001/src/api.cc#newcode6946
src/api.cc:6946: if (object_type == nullptr) {
Is object type ever expected to be null? If so why does it imply that
object count should be 0? Maybe add a comment
https://codereview.chromium.org/1113233002/diff/20001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1113233002/diff/20001/src/heap/heap.h#newcode1455
src/heap/heap.h:1455: const char* GetObjectTypeName(size_t index);
Should this be near the other ones you are adding?
https://codereview.chromium.org/1113233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
