comments inline.
https://codereview.chromium.org/1113233002/diff/20001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1113233002/diff/20001/src/api.cc#newcode6928
src/api.cc:6928: size_t Isolate::NumberOfHeapObjectsTypes() {
primiano@ here is the definition.
https://codereview.chromium.org/1113233002/diff/20001/src/api.cc#newcode6946
src/api.cc:6946: if (object_type == nullptr) {
On 2015/05/05 14:17:53, Primiano Tucci wrote:
Is object type ever expected to be null? If so why does it imply that
object
count should be 0? Maybe add a comment
The object type can be null in some cases, there are 241 object types
defined in multiple macros. but they are not continuous sequences.
DCHECK here is to check if no object type exists that is counted but not
named. will write a comment.
https://codereview.chromium.org/1113233002/diff/20001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1113233002/diff/20001/src/heap/heap.h#newcode1455
src/heap/heap.h:1455: const char* GetObjectTypeName(size_t index);
On 2015/05/05 14:17:53, Primiano Tucci wrote:
Should this be near the other ones you are adding?
the previous function does the same kind of operations. that is why this
function is added here. if the way in which the type index is handled
changes, then these functions change together.
Note: I am not sure if this function should be a part of Heap class.
Maybe this should be in objects.h . Waiting for owner's comment on that.
https://codereview.chromium.org/1113233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
