On 2015/05/05 14:48:01, ssid wrote:
ulan@ : Please review the changes.
Note:
The function Heap::GetObjectTypeName is implemented in Heap since the
OBJECT_STATS_COUNT is defined in here and the function
Heap::CheckpointObjectStats does similar indexing. So, it will be easier
to
change these both together when rquired. But I also think objects.h is the
correct place for this function. WDYT?
https://codereview.chromium.org/1113233002/diff/20001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1113233002/diff/20001/src/heap/heap.h#newcode1021
src/heap/heap.h:1021: return object_counts_last_time_[type];
On 2015/05/05 14:01:55, picksi wrote:
> Should we DCHECK the array bounds here for safety? e.g. type>=0 and
> type<object_types?
Done.
Thanks!
https://codereview.chromium.org/1113233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
