https://codereview.chromium.org/1115263004/diff/60001/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):
https://codereview.chromium.org/1115263004/diff/60001/src/compiler/js-inlining.cc#newcode368
src/compiler/js-inlining.cc:368: if (is_strong(info.language_mode()) &&
Is this checking the right language mode? It is the mode of the inlinee
that is relevant here.
https://codereview.chromium.org/1115263004/diff/60001/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/1115263004/diff/60001/src/messages.js#newcode185
src/messages.js:185: strong_mode_too_few_arguments: ["In strong mode,
calling a function with too few arguments is deprecated"],
Nit: strong_arity
https://codereview.chromium.org/1115263004/diff/60001/test/mjsunit/strong/declaration-after-use.js
File test/mjsunit/strong/declaration-after-use.js (right):
https://codereview.chromium.org/1115263004/diff/60001/test/mjsunit/strong/declaration-after-use.js#newcode214
test/mjsunit/strong/declaration-after-use.js:214: func4(1, 2); // FIXME
Why FIXME?
https://codereview.chromium.org/1115263004/diff/60001/test/mjsunit/strong/function-arity.js
File test/mjsunit/strong/function-arity.js (right):
https://codereview.chromium.org/1115263004/diff/60001/test/mjsunit/strong/function-arity.js#newcode15
test/mjsunit/strong/function-arity.js:15: f.call(undefined);
Perhaps add f.call() and f.apply() (here and elsewhere)
https://codereview.chromium.org/1115263004/diff/60001/test/mjsunit/strong/function-arity.js#newcode23
test/mjsunit/strong/function-arity.js:23: f.apply(undefined,
[undefined]);
Also add tests for .bind, %Call, %Apply, %_CallFunction (here and
elsewhere). And we should have cctests exercising invocation through the
API, because that might take yet more paths. Cross-language-mode calls
are also test-worthy, especially with cross-mode inlining (that has been
a tricky issue with the implicit conversion changes, for example).
https://codereview.chromium.org/1115263004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
