PTAL
https://codereview.chromium.org/1115263004/diff/60001/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/1115263004/diff/60001/src/messages.js#newcode185
src/messages.js:185: strong_mode_too_few_arguments: ["In strong mode,
calling a function with too few arguments is deprecated"],
On 2015/05/05 14:26:19, rossberg wrote:
Nit: strong_arity
Done.
https://codereview.chromium.org/1115263004/diff/60001/test/mjsunit/strong/declaration-after-use.js
File test/mjsunit/strong/declaration-after-use.js (right):
https://codereview.chromium.org/1115263004/diff/60001/test/mjsunit/strong/declaration-after-use.js#newcode214
test/mjsunit/strong/declaration-after-use.js:214: func4(1, 2); // FIXME
On 2015/05/05 14:26:20, rossberg wrote:
Why FIXME?
Let me make that more explicit.
The arity checking is not correct when spread params are present. The
number of required arguments for func4 should be 1 and not 2.
https://codereview.chromium.org/1115263004/diff/60001/test/mjsunit/strong/function-arity.js
File test/mjsunit/strong/function-arity.js (right):
https://codereview.chromium.org/1115263004/diff/60001/test/mjsunit/strong/function-arity.js#newcode15
test/mjsunit/strong/function-arity.js:15: f.call(undefined);
On 2015/05/05 14:26:20, rossberg wrote:
Perhaps add f.call() and f.apply() (here and elsewhere)
Done.
https://codereview.chromium.org/1115263004/diff/60001/test/mjsunit/strong/function-arity.js#newcode23
test/mjsunit/strong/function-arity.js:23: f.apply(undefined,
[undefined]);
On 2015/05/05 14:26:20, rossberg wrote:
Also add tests for .bind, %Call, %Apply, %_CallFunction (here and
elsewhere).
And we should have cctests exercising invocation through the API,
because that
might take yet more paths. Cross-language-mode calls are also
test-worthy,
especially with cross-mode inlining (that has been a tricky issue with
the
implicit conversion changes, for example).
Your wish is my command.
Done.
If you can think of any more tests I'm happy to add even more of'em.
https://codereview.chromium.org/1115263004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
