https://codereview.chromium.org/1115263004/diff/60001/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):
https://codereview.chromium.org/1115263004/diff/60001/src/compiler/js-inlining.cc#newcode368
src/compiler/js-inlining.cc:368: if (is_strong(info.language_mode()) &&
On 2015/05/05 14:26:19, rossberg wrote:
Is this checking the right language mode? It is the mode of the
inlinee that is
relevant here.
Yes, I think it is using the correct CompilationInfo here. Here "info"
refers to the the inlinee (see lines 324 and 325 above). Maybe making
that explicit by lifting the language mode out into a local variable
would avoid that confusion. On the other hand, hoisting to a local
variable needs to happen _after_ the Compiler::ParseAndAnalyze step.
https://codereview.chromium.org/1115263004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
