https://codereview.chromium.org/1127063003/diff/100001/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/1127063003/diff/100001/src/scopes.cc#newcode513
src/scopes.cc:513: void Scope::ShadowParametersForExpressions() {
On 2015/05/20 11:29:38, caitp wrote:
On 2015/05/20 07:41:47, rossberg wrote:
> On 2015/05/12 14:34:17, caitp wrote:
> > On 2015/05/12 14:04:53, rossberg wrote:
> > > Instead of spreading this out into a different function, can't
we do that
> > during
> > > desugaring, right before invoking re-Declare on the respective
variable in
> > > DesugarInitializedPArameters?
> >
> > well the scope VariableMap is private, so it's hard for the parser
to do
> itself
> > --- do you mean just get rid of the parser version of the
function?
>
> Well, this whole removing variables from scope thing still worries
me. Do you
> think it would be possible to reuse the same variables in the
desugaring
instead
> of removing and re-Declare-ing them? I figure you'd still need to do
some
> adjustments (e.g. modifying their VariableMode), but those may be
less
drastic.
I can try it
I'm not totally sure what needs to change.
Right now, I'm changing the parameter to be a lexical declaration, and
making sure it is allocated with AllocateLocal. However, this seems to
break the TDZ behaviour. It worked a lot better when the var was
completely re-declared
https://codereview.chromium.org/1127063003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
