On 2015/05/20 17:05:16, caitp wrote:
https://codereview.chromium.org/1127063003/diff/200001/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/1127063003/diff/200001/src/scopes.cc#newcode1433
src/scopes.cc:1433: if (IsLexicalVariableMode(var->mode())) {
So this approach doesn't work --- it causes the
`DCHECK(stack_locals[i]->index()
== first_slot_index + i);` in scopeinfo.cc to fail, and it doesn't really
fix
anything
So, I didn't have much luck just changing the original variable. But, I've
fixed
up the bugs identified previously with eval(), and it works beautifully.
It's probably not written in a way that will make support for binding
patterns
in parameters easy, though.
https://codereview.chromium.org/1127063003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
