https://codereview.chromium.org/1168093002/diff/120001/src/code-factory.h
File src/code-factory.h (right):
https://codereview.chromium.org/1168093002/diff/120001/src/code-factory.h#newcode44
src/code-factory.h:44: LanguageMode language_mode);
On 2015/06/09 10:56:11, Michael Starzinger wrote:
nit: I think the language mode should be the second argument, so that
this
signature continues to be an extension of the KeyedLoadIC above.
Done.
https://codereview.chromium.org/1168093002/diff/120001/src/compiler/js-operator.cc
File src/compiler/js-operator.cc (right):
https://codereview.chromium.org/1168093002/diff/120001/src/compiler/js-operator.cc#newcode194
src/compiler/js-operator.cc:194: lhs.contextual_mode() ==
rhs.contextual_mode() &&
On 2015/06/09 10:54:13, Michael Starzinger wrote:
This operator should be adapted as well.
Done.
https://codereview.chromium.org/1168093002/diff/120001/src/compiler/js-operator.cc#newcode206
src/compiler/js-operator.cc:206: return base::hash_combine(p.name(),
p.contextual_mode(), p.feedback());
On 2015/06/09 10:54:13, Michael Starzinger wrote:
This operator should be adapted as well.
Done.
https://codereview.chromium.org/1168093002/diff/120001/src/compiler/js-operator.cc#newcode211
src/compiler/js-operator.cc:211: return os << Brief(*p.name().handle())
<< ", " << p.contextual_mode();
On 2015/06/09 10:54:13, Michael Starzinger wrote:
This operator should be adapted as well.
Done.
https://codereview.chromium.org/1168093002/diff/120001/src/compiler/js-operator.cc#newcode216
src/compiler/js-operator.cc:216: // Nothing special to print.
On 2015/06/09 10:54:13, Michael Starzinger wrote:
This operator should be adapted as well.
Done.
https://codereview.chromium.org/1168093002/diff/120001/src/compiler/js-operator.cc#newcode223
src/compiler/js-operator.cc:223: return lhs.feedback() ==
rhs.feedback();
On 2015/06/09 10:54:13, Michael Starzinger wrote:
This operator should be adapted as well.
Done.
https://codereview.chromium.org/1168093002/diff/120001/src/compiler/js-operator.cc#newcode240
src/compiler/js-operator.cc:240: return hash_value(p.feedback());
On 2015/06/09 10:54:13, Michael Starzinger wrote:
This operator should be adapted as well.
Done.
https://codereview.chromium.org/1168093002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
