https://codereview.chromium.org/1168093002/diff/140001/src/ic/ic-state.h
File src/ic/ic-state.h (right):
https://codereview.chromium.org/1168093002/diff/140001/src/ic/ic-state.h#newcode205
src/ic/ic-state.h:205: class ContextualModeBits : public
BitField<ContextualMode, 0, 1> {};
Why was this moved up? That looks odd...
https://codereview.chromium.org/1168093002/diff/140001/src/ic/x64/ic-x64.cc
File src/ic/x64/ic-x64.cc (right):
https://codereview.chromium.org/1168093002/diff/140001/src/ic/x64/ic-x64.cc#newcode228
src/ic/x64/ic-x64.cc:228: __ bind(&return_undefined);
This probably shouldn't be named return_undefined anymore, but rather
"absent" or so.
https://codereview.chromium.org/1168093002/diff/140001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1168093002/diff/140001/src/objects.cc#newcode130
src/objects.cc:130: MaybeHandle<Object>
Object::GetProperty(LookupIterator* it, Strength strength) {
It would be nicer if GetProperty etc would also get a LanguageMode. Both
DeleteProperty and SetProperty already get that. And if we do that, we
could encapsulate it in the LookupIterator. I see how this is a bit
annoying since you are saving bits though ... not sure.
https://codereview.chromium.org/1168093002/diff/140001/src/objects.cc#newcode152
src/objects.cc:152: if (is_strong(strength)) {
What about extracting this in a helper method. See
WriteToReadOnlyProperty for an example.
https://codereview.chromium.org/1168093002/diff/140001/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):
https://codereview.chromium.org/1168093002/diff/140001/src/runtime/runtime-classes.cc#newcode265
src/runtime/runtime-classes.cc:265: if (!proto->IsJSReceiver()) {
Helper method. If you just change the return type to MaybeHandle<Object>
and ASSIGN_RETURN_FAILURE_ON_EXCEPTION in the client you can use the
same here as in objects.cc
https://codereview.chromium.org/1168093002/diff/140001/src/runtime/runtime-classes.cc#newcode334
src/runtime/runtime-classes.cc:334: language_mode);
Not clear when you use strength and when language_mode ...
https://codereview.chromium.org/1168093002/diff/140001/src/runtime/runtime-object.cc
File src/runtime/runtime-object.cc (right):
https://codereview.chromium.org/1168093002/diff/140001/src/runtime/runtime-object.cc#newcode184
src/runtime/runtime-object.cc:184: ASSIGN_RETURN_ON_EXCEPTION(
If you don't use result you can just return GetObjectProperty(...);
https://codereview.chromium.org/1168093002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
