Currently refactoring everything back to use language mode instead of
strength,
other changes are here.
https://codereview.chromium.org/1168093002/diff/160001/src/ic/x64/ic-x64.cc
File src/ic/x64/ic-x64.cc (right):
https://codereview.chromium.org/1168093002/diff/160001/src/ic/x64/ic-x64.cc#newcode194
src/ic/x64/ic-x64.cc:194: Label done, in_bounds, return_absent;
On 2015/06/10 08:28:08, rossberg wrote:
Nit: just "absent", it doesn't necessarily return
Done.
https://codereview.chromium.org/1168093002/diff/200001/test/mjsunit/strong/load-element-mutate-backing-store.js
File test/mjsunit/strong/load-element-mutate-backing-store.js (right):
https://codereview.chromium.org/1168093002/diff/200001/test/mjsunit/strong/load-element-mutate-backing-store.js#newcode7
test/mjsunit/strong/load-element-mutate-backing-store.js:7: //
TODO(conradw): Track implementation of strong bit for other objects, add
On 2015/06/10 08:28:08, rossberg wrote:
See above
Done.
https://codereview.chromium.org/1168093002/diff/200001/test/mjsunit/strong/load-element-mutate-backing-store.js#newcode10
test/mjsunit/strong/load-element-mutate-backing-store.js:10: function
getObjects() {
On 2015/06/10 08:28:08, rossberg wrote:
See above
Done.
https://codereview.chromium.org/1168093002/diff/200001/test/mjsunit/strong/load-element-mutate-backing-store.js#newcode202
test/mjsunit/strong/load-element-mutate-backing-store.js:202: for (let
func of readStrong) {
On 2015/06/10 08:28:08, rossberg wrote:
Yeah, a quintuple loop like this is probably producing quite a
long-running
test. Maybe you don't need to test the full matrix, but just vary a
few of the
dimensions at a time?
On reflection, I may have overstated how bad the test run times are.
With the current splitting, they take comfortably less than half (worst
case) the time of the longest running mjsunit test.
https://codereview.chromium.org/1168093002/diff/200001/test/mjsunit/strong/load-element.js
File test/mjsunit/strong/load-element.js (right):
https://codereview.chromium.org/1168093002/diff/200001/test/mjsunit/strong/load-element.js#newcode7
test/mjsunit/strong/load-element.js:7: // TODO(conradw): Track
implementation of strong bit for other objects, add
On 2015/06/10 08:28:08, rossberg wrote:
Currently, the semantics does not rely on that, does it?
Err, this was just a mindless copy and paste mistake.
https://codereview.chromium.org/1168093002/diff/200001/test/mjsunit/strong/load-element.js#newcode10
test/mjsunit/strong/load-element.js:10: function getObjects() {
On 2015/06/10 08:28:08, rossberg wrote:
Other interesting cases to add:
- arguments (both strict and sloppy)
- typed arrays
- a non-standard builtin instance (e.g. of Date)
- some builtins (Object, Array, Function)
- primitives (numbers, bools, which should be wrapped implicitly)
- proxies (in a separate test file)
Done, the plan right now is to do proxies in a followup, along with the
other "odd" cases mentioned in this CL description.
https://codereview.chromium.org/1168093002/diff/200001/test/mjsunit/strong/load-element.js#newcode200
test/mjsunit/strong/load-element.js:200: // Attempting to access a
property on an objects with no defined properties
On 2015/06/10 08:28:08, rossberg wrote:
Nit: typo
Done.
https://codereview.chromium.org/1168093002/diff/200001/test/mjsunit/strong/load-property-mutate-backing-store.js
File test/mjsunit/strong/load-property-mutate-backing-store.js (right):
https://codereview.chromium.org/1168093002/diff/200001/test/mjsunit/strong/load-property-mutate-backing-store.js#newcode7
test/mjsunit/strong/load-property-mutate-backing-store.js:7: //
TODO(conradw): Track implementation of strong bit for other objects, add
On 2015/06/10 08:28:08, rossberg wrote:
See above
Done.
https://codereview.chromium.org/1168093002/diff/200001/test/mjsunit/strong/load-property-mutate-backing-store.js#newcode10
test/mjsunit/strong/load-property-mutate-backing-store.js:10: function
getObjects() {
On 2015/06/10 08:28:08, rossberg wrote:
See above
Done.
https://codereview.chromium.org/1168093002/diff/200001/test/mjsunit/strong/load-property.js
File test/mjsunit/strong/load-property.js (right):
https://codereview.chromium.org/1168093002/diff/200001/test/mjsunit/strong/load-property.js#newcode7
test/mjsunit/strong/load-property.js:7: // TODO(conradw): Track
implementation of strong bit for other objects, add
On 2015/06/10 08:28:08, rossberg wrote:
See above
Done.
https://codereview.chromium.org/1168093002/diff/200001/test/mjsunit/strong/load-property.js#newcode10
test/mjsunit/strong/load-property.js:10: function getObjects() {
On 2015/06/10 08:28:08, rossberg wrote:
See above
Done.
https://codereview.chromium.org/1168093002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
