Hi Conrad, ic stuff looks pretty good, a couple comments.
https://codereview.chromium.org/1168093002/diff/140001/src/builtins.h
File src/builtins.h (right):
https://codereview.chromium.org/1168093002/diff/140001/src/builtins.h#newcode93
src/builtins.h:93: LoadICState::kStrongModeState)
\
You don't need KeyedLoadIC_Initialize_Strong (and could delete
KeyedLoadIC_Initialize while you are at it if you like).
https://codereview.chromium.org/1168093002/diff/140001/src/ic/ic.cc
File src/ic/ic.cc (right):
https://codereview.chromium.org/1168093002/diff/140001/src/ic/ic.cc#newcode937
src/ic/ic.cc:937: return strong ?
isolate->builtins()->KeyedLoadIC_Initialize_Strong()
I think this shows some unfinished clean-up work now that vector ics
area always on for loads. We can't achieve UNINITIALIZED state here
because of the statement above ("if (initialization_state !=
MEGAMORPHIC)").
Suggests that you could eliminate KeyedLoadIC_Initialize() from the
builtins, and your strong variant then too.
https://codereview.chromium.org/1168093002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
