Comment #10 on issue 4168 by [email protected]: Array.of/from
use %AddElement unsafely
https://code.google.com/p/v8/issues/detail?id=4168
Toon, are you sure it'll call a setter if it's defined directly on the
receiver? I don't see it doing this:
d8> function a() { Object.defineProperty(this, '0', {get: function() {
return 2; }, set: function() { print("yes"); }}); }
undefined
d8> Array.of.call(a, [1])
{get 0() { return 2; }, set 0() { print("yes"); }, length: 1}
(Still, it's violating the spec by not throwing on the failed
DefineOwnProperty. The return value of %SetElement needs to be checked.)
Looking in the code, it seems like SetPropertyWithAccessor isn't called
from SetElement (instead from paths like SetPropertyInternal), so the
accessor isn't be reached.
Could you tell me more about your plan for %SetElement? What are the
semantics going to be after the rewrite?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
