Comment #15 on issue 4168 by [email protected]: Array.of/from
use %AddElement unsafely
https://code.google.com/p/v8/issues/detail?id=4168#c15
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/b23c328f53b4579fa9d9f5c2c344839244d0f526
commit b23c328f53b4579fa9d9f5c2c344839244d0f526
Author: dehrenberg <[email protected]>
Date: Thu Jun 11 20:40:54 2015
In Array.of and Array.from, fall back to DefineOwnProperty
%AddElement is not intended for objects which are not arrays, and
its behavior may go away with future refactorings. This patch gets
rid of it if the receiver of from or of is not the intrinsic Array
object.
Array.of and Array.from previously papered over failures in calling
[[DefineOwnProperty]] when setting array elements. This patch
makes them lead to exceptions, and adds tests to assert that
the appropriate exceptions are thrown.
BUG=v8:4168
R=adamk
CC=rossberg,verwaest
LOG=Y
Review URL: https://codereview.chromium.org/1181623003
Cr-Commit-Position: refs/heads/master@{#28969}
[modify]
http://crrev.com/b23c328f53b4579fa9d9f5c2c344839244d0f526/src/harmony-array.js
[modify]
http://crrev.com/b23c328f53b4579fa9d9f5c2c344839244d0f526/src/prologue.js
[modify]
http://crrev.com/b23c328f53b4579fa9d9f5c2c344839244d0f526/test/mjsunit/harmony/array-from.js
[modify]
http://crrev.com/b23c328f53b4579fa9d9f5c2c344839244d0f526/test/mjsunit/harmony/array-of.js
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
