Typing parts look okay, but I wonder if TypeSignature isn't essentially
duplicating the existing FunctionType from types.h.
Adding Benedikt, who might also want to chime in.
https://codereview.chromium.org/1197703002/diff/100001/src/compiler/typer.h
File src/compiler/typer.h (right):
https://codereview.chromium.org/1197703002/diff/100001/src/compiler/typer.h#newcode8
src/compiler/typer.h:8: #include "src/compiler.h"
Unneeded include?
https://codereview.chromium.org/1197703002/diff/100001/src/type-signature.cc
File src/type-signature.cc (right):
https://codereview.chromium.org/1197703002/diff/100001/src/type-signature.cc#newcode15
src/type-signature.cc:15: if (type->Is(Type::UntaggedSigned()) ||
type->Is(Type::UntaggedUnsigned())) {
Any reason you can't compare to UntaggedIntegral here?
https://codereview.chromium.org/1197703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
