https://codereview.chromium.org/1197703002/diff/140001/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/1197703002/diff/140001/src/code-stubs.cc#newcode1050
src/code-stubs.cc:1050: Representation RepresentationFromType(Type*
type) {
So UntaggedFloat64 and UntaggedFloat32 are mapped to
Representation::Tagged? That should be fixed to Representation::Double
even if we don't use that currently.
https://codereview.chromium.org/1197703002/diff/140001/src/compiler.h
File src/compiler.h (right):
https://codereview.chromium.org/1197703002/diff/140001/src/compiler.h#newcode292
src/compiler.h:292: void SetFunctionType(Type::FunctionType*
function_type) {
Nit: I think Type::FunctionType is an implementation detail of the type
system and should not be exposed? Use Type* instead.
https://codereview.chromium.org/1197703002/diff/140001/src/compiler.h#newcode488
src/compiler.h:488: Type::FunctionType* function_type_;
See above.
https://codereview.chromium.org/1197703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
