Feedback addressed, landing
https://codereview.chromium.org/1197703002/diff/140001/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/1197703002/diff/140001/src/code-stubs.cc#newcode1050
src/code-stubs.cc:1050: Representation RepresentationFromType(Type*
type) {
On 2015/06/22 06:51:29, jarin wrote:
On 2015/06/22 05:27:28, Benedikt Meurer wrote:
> So UntaggedFloat64 and UntaggedFloat32 are mapped to
Representation::Tagged?
> That should be fixed to Representation::Double even if we don't use
that
> currently.
I would slightly prefer if handled only the cases that we really have
and then
do UNREACHABLE for the cases we should not get (such as
UntaggedFloat64).
Done.
https://codereview.chromium.org/1197703002/diff/140001/src/code-stubs.cc#newcode1050
src/code-stubs.cc:1050: Representation RepresentationFromType(Type*
type) {
On 2015/06/22 05:27:28, Benedikt Meurer wrote:
So UntaggedFloat64 and UntaggedFloat32 are mapped to
Representation::Tagged?
That should be fixed to Representation::Double even if we don't use
that
currently.
I think I prefer Jaro's suggestion for now, since we don't test these
cases and I'd rather not build in code that isn't actually used.
https://codereview.chromium.org/1197703002/diff/140001/src/compiler.h
File src/compiler.h (right):
https://codereview.chromium.org/1197703002/diff/140001/src/compiler.h#newcode292
src/compiler.h:292: void SetFunctionType(Type::FunctionType*
function_type) {
On 2015/06/22 05:27:28, Benedikt Meurer wrote:
Nit: I think Type::FunctionType is an implementation detail of the
type system
and should not be exposed? Use Type* instead.
As discussed over chat with you and Jaro, I'm going to leave this as-is
for now.
https://codereview.chromium.org/1197703002/diff/140001/src/interface-descriptors.cc
File src/interface-descriptors.cc (right):
https://codereview.chromium.org/1197703002/diff/140001/src/interface-descriptors.cc#newcode14
src/interface-descriptors.cc:14: static Type* SmiType() {
On 2015/06/22 06:51:29, jarin wrote:
I believe you do not have to say 'static' if you are already in an
anonymous
namespace.
Done.
https://codereview.chromium.org/1197703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
