Just nits from side. Otherwise, lgtm.
https://codereview.chromium.org/1197703002/diff/140001/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/1197703002/diff/140001/src/code-stubs.cc#newcode1050
src/code-stubs.cc:1050: Representation RepresentationFromType(Type*
type) {
On 2015/06/22 05:27:28, Benedikt Meurer wrote:
So UntaggedFloat64 and UntaggedFloat32 are mapped to
Representation::Tagged?
That should be fixed to Representation::Double even if we don't use
that
currently.
I would slightly prefer if handled only the cases that we really have
and then do UNREACHABLE for the cases we should not get (such as
UntaggedFloat64).
https://codereview.chromium.org/1197703002/diff/140001/src/interface-descriptors.cc
File src/interface-descriptors.cc (right):
https://codereview.chromium.org/1197703002/diff/140001/src/interface-descriptors.cc#newcode14
src/interface-descriptors.cc:14: static Type* SmiType() {
I believe you do not have to say 'static' if you are already in an
anonymous namespace.
https://codereview.chromium.org/1197703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
