Comments addressed (sorry had to rebase).
PTAL
https://codereview.chromium.org/1189743003/diff/60001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1189743003/diff/60001/src/parser.cc#newcode4301
src/parser.cc:4301:
On 2015/06/19 19:25:26, arv wrote:
-1 newline
Done.
https://codereview.chromium.org/1189743003/diff/60001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/1189743003/diff/60001/src/parser.h#newcode554
src/parser.h:554:
On 2015/06/19 19:25:26, arv wrote:
-1 newline
Done.
https://codereview.chromium.org/1189743003/diff/60001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1189743003/diff/60001/src/preparser.h#newcode2418
src/preparser.h:2418:
classifier->RecordDuplicateFormalParameterError(scanner()->location());
On 2015/06/19 19:25:26, arv wrote:
The following is not supposed to be an error.
function f({x: y, x: z}) {}
Can you add a test that this works?
Done.
https://codereview.chromium.org/1189743003/diff/60001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1189743003/diff/60001/test/cctest/test-parsing.cc#newcode6627
test/cctest/test-parsing.cc:6627: "var f = {x,y} => {};",
On 2015/06/19 16:26:35, rossberg wrote:
{x,x} ? But isn't this a plain syntax error anyway?
Moved to separate test.
https://codereview.chromium.org/1189743003/diff/60001/test/cctest/test-parsing.cc#newcode6653
test/cctest/test-parsing.cc:6653: "var f = {x} => {};",
On 2015/06/19 16:26:35, rossberg wrote:
Same here, this test is unrelated to duplicates.
Moved to separate test.
https://codereview.chromium.org/1189743003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
