LGTM with nit above about rest patterns.
That said :) Is this expected to work for initializers of eagerly-parsed
arrow
functions? I would expect that the literal_count() or the property_count()
of
the initializers would be recorded in the outer scope and not in the arrow
function's scope, and so you'd have to fix up somethingorother. Where would
that happen?
https://codereview.chromium.org/1189743003/diff/80001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1189743003/diff/80001/src/parser.cc#newcode2057
src/parser.cc:2057: Expression* expression = NewThrowSyntaxError(
nice!
https://codereview.chromium.org/1189743003/diff/80001/src/parser.cc#newcode3848
src/parser.cc:3848:
parser_->scope_->RemoveUnresolved(expr->AsVariableProxy());
I see, for patterns this happens in
Parser::PatternRewriter::VisitVariableProxy. A comment would be
appreciated tho :)
https://codereview.chromium.org/1189743003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
