Thanks all!
https://codereview.chromium.org/1230753004/diff/240001/src/objects-debug.cc
File src/objects-debug.cc (right):
https://codereview.chromium.org/1230753004/diff/240001/src/objects-debug.cc#newcode552
src/objects-debug.cc:552: VerifyObjectField(kFunctionDataOffset);
On 2015/07/22 07:44:00, rmcilroy wrote:
Could you add a CHECK here that kFunctionDataOffset is either a
FunctionTemplateInfo, a Smi, a BytecodeArray or Undefined.
Done. And added call to verify Smi/BytecodeArray.
https://codereview.chromium.org/1230753004/diff/240001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1230753004/diff/240001/src/objects.h#newcode6714
src/objects.h:6714: DECL_ACCESSORS(bytecode_array, BytecodeArray)
On 2015/07/22 07:20:54, Michael Starzinger wrote:
nit: These declarations have become obsolete, let's drop them. The
getter is
declared below and if we ever need a setter, we should also explicitly
declare
it below.
Done.
https://codereview.chromium.org/1230753004/diff/240001/src/objects.h#newcode6730
src/objects.h:6730: // - a bytecode array for the interpreter
[HasBytecodeArray()].
On 2015/07/22 07:44:00, rmcilroy wrote:
nit /s/bytecode array/BytecodeArray
Done.
https://codereview.chromium.org/1230753004/diff/240001/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/1230753004/diff/240001/src/types.cc#newcode1
src/types.cc:1:
On 2015/07/22 08:11:58, ulan wrote:
Delete empty line.
Done.
https://codereview.chromium.org/1230753004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
