On 2015/07/21 12:51:04, Michael Starzinger wrote:
Drive-by ...

How about we use the SharedFunctionInfo::function_data for that overloading?
This field is currently used for two purposes ...

1) For API function which are backed by C++ implementation. I don't think we
will ever need bytecode for them. :)

2) For number special builtin functions. For now we would just exclude these functions from being interpreted. See the FUNCTIONS_WITH_ID_LIST list in the
objects.h file for a list of what we are talking about here.

The above two cases are clearly distinguishable from bytecode, as either
IsSmi()
or IsFunctionTemplateInfo() will hold for them respectively.

WDYT?

Great spot, let's try it. I'll rev the patch and add a test for BytecodeArray in
in test-heap.cc.
Thanks!


https://codereview.chromium.org/1230753004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to