Everything looks good, except:
1) Memory overhead (see comment below).
2) Please add a test that creates bytecode array, checks, and does GC.
https://codereview.chromium.org/1230753004/diff/220001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1230753004/diff/220001/src/objects.h#newcode6710
src/objects.h:6710: DECL_ACCESSORS(bytecode_array, BytecodeArray)
This will increase memory footprint. Couple of month ago I saw that
google inbox had ~50K shared function infos. So this would mean
additional 200K-400K live memory depending on architecture.
Maybe we can find a way to stash the pointer somewhere, so that we pay
the cost only when there is an actual byte array? Or do this behind
build flag.
https://codereview.chromium.org/1230753004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
