lgtm other than the dissasembly (which I think should be in a different CL).
Ulan: Could you take a look please?
https://codereview.chromium.org/1230753004/diff/220001/src/interpreter/bytecodes.h
File src/interpreter/bytecodes.h (right):
https://codereview.chromium.org/1230753004/diff/220001/src/interpreter/bytecodes.h#newcode50
src/interpreter/bytecodes.h:50: static const int kMaximumSize = 1 +
kMaximumNumberOfArguments;
Is this just used for the disassembly? I don't think we should have this
here just for that, isn't there another way of formatting the
disassembly to avoid having to hard-code the maximum number of bytecode
arguments?
https://codereview.chromium.org/1230753004/diff/220001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1230753004/diff/220001/src/objects.cc#newcode11817
src/objects.cc:11817: os << bytecode;
What does this print out, it's hard to see from the code. I was hoping
for something like:
0x4e327c60 0 0001 LoadLiteral0 [1]
0x4e327c62 2 01 Return
(like the code disassembly)
Would it be possible to do something like this? If you like we can just
put a TODO in here and do the actual disassembly as a separate CL.
https://codereview.chromium.org/1230753004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
