Kevin,
Could you please look at this addition to the compiler infrastructure? Will
it
be possible to combine this with the compiler enhancements currently being
worked on?
Peter,
Please drop ENABLE_LIVEEDIT_SUPPORT and instead hide live edit behind the
flag
(flag-definitions.h) FLAG_live_edit. The use of the spy could then include
the
flag check in IsActive (or the listener will stay as NULL if the flag is not
enabled). Having a "spy" which does nothing should be possible without
impacting
performance.
When adding new files please update the other build systems as well.
Updating
tools/gyp/v8.gyp is required for Chromium build. And if possibly also update
files in tools/v8.xcodeproj and tools/visual_studio.
http://codereview.chromium.org/607004/diff/10/1015
File src/liveedit.cc (right):
http://codereview.chromium.org/607004/diff/10/1015#newcode65
src/liveedit.cc:65: : listener_(active_function_info_listener)
Is the member listener_ actually required?
http://codereview.chromium.org/607004/diff/10/1015#newcode86
src/liveedit.cc:86: bool LiveEditFunctionSpy::IsActive() {
How about making this inline this and use it in the functions above
(replacing listener_ != NULL)?
http://codereview.chromium.org/607004/diff/10/1016
File src/liveedit.h (right):
http://codereview.chromium.org/607004/diff/10/1016#newcode50
src/liveedit.h:50: //
Please remove this feature request comment.
http://codereview.chromium.org/607004/diff/10/1016#newcode76
src/liveedit.h:76: class LiveEditFunctionSpy {
How about changing Spy to Tracker, or something like this.
http://codereview.chromium.org/607004
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
