On 2010/02/16 09:40:09, Søren Gjesse wrote:
Peter,
Please drop ENABLE_LIVEEDIT_SUPPORT and instead hide live edit behind the
flag
(flag-definitions.h) FLAG_live_edit. The use of the spy could then
include the
flag check in IsActive (or the listener will stay as NULL if the flag is
not
enabled). Having a "spy" which does nothing should be possible without
impacting
performance.
Just one thing so far.
I will be happy to drop ENABLE_LIVEEDIT_SUPPORT.
Can I offer using ENABLE_DEBUGGER_SUPPORT instead? (in some places?)
Anyway having this code compiled unconditionally is fine with me.
http://codereview.chromium.org/607004
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
